Update links to Universal examples in README.md #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `universal/CMakeLists.txt` has been edited, so the line-numbers had drifted
| @@ -386,9 +386,9 @@ These require you to set `PICO_ARM_TOOLCHAIN_PATH` and `PICO_RISCV_TOOLCHAIN_PAT | |||
|
|
|||
| App|Description | |||
| ---|--- | |||
| [blink](universal/CMakeLists.txt#L126) | Same as the [blink](blink) example, but universal. | |||
| [blink](universal/CMakeLists.txt#L137) | Same as the [blink](blink) example, but universal. | |||
There was a problem hiding this comment.
Why are the line numbers there at all?
There was a problem hiding this comment.
According to git blame, the line-numbers first appeared in 7fe60d6
Ping @will-v-pi and @kilograham
There was a problem hiding this comment.
It’s because those examples don’t have their own folders, they’re just created by lines in the CMakeLists.txt file. The actual example code is in the normal blink/nuke folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
universal/CMakeLists.txthas been edited, so the line-numbers had drifted